anthonychengit opened a new pull request, #7995:
URL: https://github.com/apache/texera/pull/7995

   ### What changes were proposed in this PR?
   
   Rename the repeat row's <code>*ngFor</code> variable so it no longer shadows 
the component's <code>field</code>. The remove buttons now read the 
section-level <code>templateOptions.disabled</code>, matching the add button.
   
   | Before | After |
   | --- | --- |
   | Remove buttons stay active while the section is disabled. | All remove 
buttons and the add button are disabled together. |
   
   <!-- Replace with the actual side-by-side Chromium screenshots before 
marking ready. -->
   
   Permanent rendering tests cover both directions: every remove button is 
disabled for a disabled section, and every remove button remains available 
otherwise.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7431
   
   ### How was this PR tested?
   
   ~~~powershell
   cd frontend
   node node_modules\@angular\cli\bin\ng.js test --watch=false --include 
src/app/common/formly/repeat-dnd/repeat-dnd.component.spec.ts
   node .yarn\releases\yarn-4.14.1.cjs run format:ci
   git diff --check
   ~~~
   
   Result: 14 tests passed; the frontend Prettier and ESLint CI check passed; 
<code>git diff --check</code> passed.
   
   The before/after evidence was captured from the actual Angular component in 
Playwright Chromium with <code>templateOptions.disabled = true</code>.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: OpenAI Codex (GPT-5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to