kunwp1 commented on code in PR #7820: URL: https://github.com/apache/texera/pull/7820#discussion_r3863777873
########## frontend/src/app/common/service/warehouse/warehouse-actions.service.ts: ########## @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { Injectable } from "@angular/core"; +import { NzModalService } from "ng-zorro-antd/modal"; +import { Observable, firstValueFrom } from "rxjs"; +import { NotificationService } from "../notification/notification.service"; +import { DashboardWarehouse } from "../../type/warehouse"; +import { extractErrorMessage } from "../../util/error"; +import { WarehouseService } from "./warehouse.service"; + +/** + * Shared warehouse actions (#6933), mirroring ComputingUnitActionsService: + * create and delete sit behind one service so the confirm dialog and its + * wording live in one place, shared with the workspace picker once it lands + * (#7817). + */ +@Injectable({ + providedIn: "root", +}) +export class WarehouseActionsService { + constructor( + private modalService: NzModalService, + private warehouseService: WarehouseService, + private notificationService: NotificationService + ) {} + + /** Creates a warehouse, so create and delete both sit behind this service. */ + create(name: string): Observable<DashboardWarehouse> { + return this.warehouseService.createWarehouse(name); + } + + /** + * Asks for confirmation, then deletes the warehouse and all data stored in it. + * Runs `onDeleted` after a successful delete so the caller can refresh its + * list (warehouses have no push stream to do that for them, unlike computing + * units). + * + * `nzOnOk` returns a promise so the dialog keeps its OK button spinning until + * the request settles: deleting a warehouse that still holds data waits out + * Lakekeeper's asynchronous purge (#7742) — bounded at roughly 16 seconds by + * the backend's backoff — and closing the dialog immediately would read as a + * frozen row. + */ + confirmAndDelete(warehouse: DashboardWarehouse, onDeleted: () => void): void { + this.modalService.confirm({ + nzTitle: `Delete warehouse "${warehouse.name}"?`, + nzContent: "This permanently deletes the warehouse and all data stored in it.", + nzOkText: "Delete", + nzOkDanger: true, + // Resolves on failure too: the error is reported as a toast, and leaving the + // confirm dialog open on top of it would just have to be dismissed twice. + // Two callbacks rather than .then().catch(): chaining would route a throw + // from onDeleted into the delete-failed branch, reporting a failure over a + // delete that succeeded. The callback is guarded for the same reason — a + // refresh that fails must not reject the dialog either. + nzOnOk: () => Review Comment: You can add an `async` to make it cleaner. After that, you can also trim some of the comments above. ########## frontend/src/app/common/service/warehouse/warehouse-actions.service.ts: ########## @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { Injectable } from "@angular/core"; +import { NzModalService } from "ng-zorro-antd/modal"; +import { Observable, firstValueFrom } from "rxjs"; +import { NotificationService } from "../notification/notification.service"; +import { DashboardWarehouse } from "../../type/warehouse"; +import { extractErrorMessage } from "../../util/error"; +import { WarehouseService } from "./warehouse.service"; + +/** + * Shared warehouse actions (#6933), mirroring ComputingUnitActionsService: + * create and delete sit behind one service so the confirm dialog and its Review Comment: I think this comment doesn't apply to `create()` comparing to `delete()`. Either update the comment or update `create()` to match the comment. ########## frontend/src/app/common/service/warehouse/warehouse-actions.service.spec.ts: ########## @@ -0,0 +1,144 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { TestBed } from "@angular/core/testing"; +import { Subject, firstValueFrom, of, throwError } from "rxjs"; +import { NzModalService } from "ng-zorro-antd/modal"; +import { WarehouseActionsService } from "./warehouse-actions.service"; +import { WarehouseService } from "./warehouse.service"; +import { NotificationService } from "../notification/notification.service"; +import { DashboardWarehouse } from "../../type/warehouse"; + +describe("WarehouseActionsService", () => { + let service: WarehouseActionsService; + let modalService: { confirm: ReturnType<typeof vi.fn> }; + let warehouseService: { createWarehouse: ReturnType<typeof vi.fn>; deleteWarehouse: ReturnType<typeof vi.fn> }; + let notificationService: { error: ReturnType<typeof vi.fn>; success: ReturnType<typeof vi.fn> }; + + const warehouse: DashboardWarehouse = { + whid: 3, + name: "sales", + lakekeeperWarehouseName: "user-1-3", + flavor: "local", + createdAtMillis: 0, + ownerName: "Alice", + ownerAvatar: null, + }; + + beforeEach(() => { + modalService = { confirm: vi.fn() }; + warehouseService = { + createWarehouse: vi.fn().mockReturnValue(of(warehouse)), + deleteWarehouse: vi.fn().mockReturnValue(of(void 0)), + }; + notificationService = { error: vi.fn(), success: vi.fn() }; + + TestBed.configureTestingModule({ + providers: [ + WarehouseActionsService, + { provide: NzModalService, useValue: modalService }, + { provide: WarehouseService, useValue: warehouseService }, + { provide: NotificationService, useValue: notificationService }, + ], + }); + service = TestBed.inject(WarehouseActionsService); + }); + + it("creates through the warehouse service, so create and delete share one entry point", async () => { + const created = await firstValueFrom(service.create("mybucket")); + + expect(warehouseService.createWarehouse).toHaveBeenCalledWith("mybucket"); + expect(created).toEqual(warehouse); + }); + + it("asks for confirmation with the danger wording, without deleting yet", () => { + const onDeleted = vi.fn(); + + service.confirmAndDelete(warehouse, onDeleted); + + expect(modalService.confirm).toHaveBeenCalledTimes(1); + const config = modalService.confirm.mock.calls[0][0]; Review Comment: I see so many duplication of this code and line 88. Can you refactor the code? ########## frontend/src/app/common/type/warehouse.ts: ########## @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * A per-user warehouse registration (#6870), as served by `GET /warehouse/status`. + * Mirrors the backend's `WarehouseResource.DashboardWarehouse`. + */ +export interface DashboardWarehouse { + whid: number; + /** The user-facing name, unique per user and free to change. */ + name: string; + /** The Lakekeeper catalog name (`user-<uid>-<whid>`), stable for life (#7753). */ + lakekeeperWarehouseName: string; + /** The storage backing the warehouse; matches the backend's user_warehouse_flavor enum. */ Review Comment: Should be `user_warehouse_flavor_enum`. ########## frontend/src/app/common/type/warehouse.ts: ########## @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * A per-user warehouse registration (#6870), as served by `GET /warehouse/status`. Review Comment: Also add POST /warehouse in the comment. ########## frontend/src/app/common/type/warehouse.ts: ########## @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * A per-user warehouse registration (#6870), as served by `GET /warehouse/status`. + * Mirrors the backend's `WarehouseResource.DashboardWarehouse`. + */ +export interface DashboardWarehouse { + whid: number; + /** The user-facing name, unique per user and free to change. */ + name: string; + /** The Lakekeeper catalog name (`user-<uid>-<whid>`), stable for life (#7753). */ + lakekeeperWarehouseName: string; + flavor: string; Review Comment: Even to match with `user_warehouse_flavor_enum`, can you just add a new type something similar to `WorkflowComputingUnitType`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
