Yicong-Huang opened a new issue, #8053: URL: https://github.com/apache/texera/issues/8053
### What happened? Committing an operator rename with the Enter key stores a literal newline in the operator's saved display name. The editor closes and the rename looks like it worked, so nothing signals that the name is now malformed. The newline goes into the collaborative shared document, so it reaches every co-editor, is persisted, and returns on each later load. The port title editor has the same defect. Expected: Enter commits the rename and closes the editor without altering the text. The title editors were built to do this, and deliberately suppress newline insertion, because a display name is a single-line value. The suppression stopped working when the frontend moved to Quill 2 in #6418. The editors still describe their Enter handling the way the previous major version expected. The new version interprets that differently: it runs its own default Enter behavior, which inserts the newline, and never reaches the editors' own handler. Only the visible half of the intended behavior survives, because closing the editor is triggered separately on key release, after the newline is already written. Impact is small per occurrence, but it accumulates in stored workflow content and is invisible to the person causing it. Renaming with Enter is the ordinary gesture, so most renames since #6418 are affected. Related: #7351 removes the disabled collaborative form-field wrapper, one of three places carrying this defect. That component is already unreachable, so it neither fixes nor covers this. The reachable editors are the operator and port title ones, untouched by that PR. ### How to reproduce? 1. Open any workflow in the editor. 2. Click an operator's title to start editing it. 3. Type a new name. 4. Press Enter to commit. The editor closes and the name looks correct. Reopen the title editor, or reload the workflow, and the trailing newline is in the stored value. The same steps against a port title reproduce it there. No test covers the title editors' keyboard behavior, so CI does not catch this. ### Version/Branch 1.3.0-incubating-SNAPSHOT (main) ### Commit Hash (Optional) b01b11f81 — verified still present on main at this commit. ### What browsers are you seeing the problem on? Chrome -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
