tanishqgandhi1908 commented on code in PR #7937:
URL: https://github.com/apache/texera/pull/7937#discussion_r3874771974
##########
file-service/src/main/scala/org/apache/texera/service/resource/ModelResource.scala:
##########
@@ -147,6 +172,13 @@ object ModelResource {
case class ModelNameModification(mid: Integer, name: String)
+ case class ModelFrameworkModification(mid: Integer, framework: String)
+
+ case class ModelFormatModification(mid: Integer, format: String)
+
+ /** Committed image, relative to the model root, e.g. "v1 - init/cover.jpg".
*/
+ case class CoverImageRequest(coverImage: String)
Review Comment:
Fair — same argument, and cheaper now than later. Moved it to
`CoverImageUtils`, both resources import it, endpoint signatures unchanged. The
test references became `CoverImageUtils.CoverImageRequest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
