PG1204 commented on issue #5726: URL: https://github.com/apache/texera/issues/5726#issuecomment-5612920607
@Xiao-zhen-Liu since #6927 is merged, checking in on the re-scope that you had mentioned in the review. Summary of where this landed: #6075 unified how both callers obtain Validation and removed the fallback. #6927 added the guard on changeOperatorColor, so the second border write on add skips the attrs deep-clone. You also confirmed the ordering in this issue's description is reversed (validation paints first, add handler last), so dropping applyOperatorBorder from the add handler is not safe for #3614. The one remaining item is validateOperator running twice per add (once via the dynamic-schema stream in ValidationWorkflowService, once in the operator-add subscriber). Options as I see them: - Close this issue as done, and file a narrow follow-up for the double validateOperator call if you think it's worth measuring. - Re-scope this issue to just that double call and I'll take it. - Close as-is; the remaining cost is a pure-function recompute with no visible effect. Happy with any of these. If it's 1 or 2, I can attach a quick timing of validateOperator on a large workflow so the decision is based on a number rather than a guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
