zyratlo commented on PR #8544: URL: https://github.com/apache/texera/pull/8544#issuecomment-5668146909
## Line breakdown of this PR 1,473 non-blank lines added, 142 removed. Percentages are of non-blank added lines. The 226 blank lines added and the 71 KB PNG asset are excluded. ### By category | Category | Lines | Share | |---|---:|---:| | Test code | 629 | 42.7% | | Production code (TS, HTML, SCSS) | 455 | 30.9% | | Comments and doc comments | 198 | 13.4% | | LLM prompt text | 155 | 10.5% | | Apache license headers | 36 | 2.4% | | **Total** | **1,473** | **100%** | ### Per file | File | Code | Comments | Prompt / license | Removed | |---|---:|---:|---:|---:| | `script-segmentation.spec.ts` | 250 | 4 | 18 | 0 | | `migration-llm.spec.ts` | 125 | 13 | 0 | 0 | | `notebook-import-modal.component.html` | 111 | 1 | 0 | 55 | | `script-segmentation.ts` | 107 | 47 | 18 | 0 | | `notebook-import-modal.component.spec.ts` | 104 | 13 | 0 | 2 | | `migration-llm.ts` | 97 | 56 | 0 | 35 | | `user-workflow.component.spec.ts` | 77 | 3 | 0 | 5 | | `notebook-migration.service.spec.ts` | 73 | 4 | 0 | 0 | | `user-workflow.component.ts` | 55 | 19 | 0 | 21 | | `notebook-migration.service.ts` | 54 | 16 | 0 | 12 | | `notebook-import-modal.component.scss` | 15 | 8 | 0 | 4 | | `notebook-import-modal.component.ts` | 14 | 14 | 0 | 3 | | `migration-prompts.ts` | 0 | 0 | 155 | 0 | | `user-workflow.component.html` | 2 | 0 | 0 | 2 | ### Notes Test code outweighs production code 1.4 to 1, and 1.9 to 1 against production TypeScript alone. Most of that sits in `script-segmentation.spec.ts`, which is where the reconciliation edge cases live: reversed, overlapping, out of order, and out of bounds ranges, plus the accepted input shapes. Comments are 31.7% of production TypeScript lines. The density is highest in `script-segmentation.ts` (47 comment lines against 107 of code), where the file-level doc comment states the invariants the algorithm guarantees. Only 142 lines were removed. 57 are template lines from restructuring the modal into tabs and 55 are TypeScript, nearly all of it code motion from extracting the shared workflow assembly out of `convertNotebookToWorkflow`. The 155 prompt lines are `migration-prompts.ts`, which is 155 insertions and 0 deletions: the script variants are additive and every notebook prompt is untouched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
