zyratlo commented on PR #8544: URL: https://github.com/apache/texera/pull/8544#issuecomment-5697567061
> The blank-gap fixture is the right fix — it exercises what the old one structurally could not. One thing to update before merge: the body still says the notebook prompts are left byte identical at 170 insertions and 0 deletions; it is 175 and 1 now, and this also corrects two pre-existing notebook-prompt bugs. Worth saying so there, since that line is what tells a reviewer they can skip the notebook path. I've updated the PR body: it now says 175 insertions and 1 deletion, and names the two notebook prompt changes explicitly, both pre-existing bugs found in this review (1e1cb94 and 242e495). I also corrected a few stale test counts and restored a paragraph on the one notebook-path behavior change, the mapping inversion now skipping a non-array cell list instead of throwing, since that is the other thing a reviewer skipping the notebook path would want to know about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
