Copilot commented on code in PR #8551:
URL: https://github.com/apache/texera/pull/8551#discussion_r4030556807
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts:
##########
@@ -226,6 +252,48 @@ export class ComputingUnitSelectionComponent implements
OnInit {
this.allComputingUnits = units;
});
+ // Warehouse picker state (#7817). The pick itself lives in
WarehouseService,
+ // where ExecuteWorkflowService reads it at execution time.
+ this.warehouseRefreshRequested$
+ .pipe(
+ switchMap(() =>
+ this.warehouseService.getStatus().pipe(
+ // Caught inside the switchMap so a failure ends only this request,
+ // not the stream.
+ catchError((err: unknown) => {
+ // The pick lives in the root-scoped service, so hiding the
picker
+ // is not enough: a stale id from a previous workflow would still
+ // ride the next execution request. Clear it whenever the picker
+ // cannot be shown.
+ this.warehouseEnabled = false;
Review Comment:
This error path fails open on an enabled deployment: setting
`warehouseEnabled` to false makes `warehouseRequiredButMissing` false, so Run
remains available and sends no `warehouseId`; the current backend then writes
to shared default storage. Preserve the boot-time feature flag (or model a
separate failed state) so a status transport failure still blocks execution
without a warehouse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
