Copilot commented on code in PR #8551:
URL: https://github.com/apache/texera/pull/8551#discussion_r4030684425
##########
frontend/src/app/workspace/service/execute-workflow/execute-workflow.service.ts:
##########
@@ -254,6 +261,7 @@ export class ExecuteWorkflowService {
workflowSettings: workflowSettings,
emailNotificationEnabled: emailNotificationEnabled,
computingUnitId: computingUnitId, // Include the computing unit ID
+ warehouseId: warehouseId,
Review Comment:
The warehouse requirement is only gated in `MenuComponent`, but other
execution paths call this service directly: `WorkflowFormComponent.onRun`,
`OperatorMenuService.executeUpToOperator`, and time-travel replay. While the
feature is enabled and no warehouse is selected (for example, with zero
warehouses or during initial loading), those paths still send `warehouseId:
undefined`, which the current backend routes to shared storage. Enforce the
flag-aware requirement in the shared execution service, or gate every execution
entry point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
