aglinxinyuan opened a new pull request, #8719: URL: https://github.com/apache/texera/pull/8719
### What changes were proposed in this PR? Deletes `dataCheck` and `filterByStatus` from `AdminExecutionComponent`, together with the `NzTableFilterFn` import and the four spec cases that exercised them. **−58 lines.** There is no behaviour change: status filtering happens on the server, and the Status column's `[nzFilterFn]="true"` is a literal flag, not a reference to `filterByStatus`. ### History | | | | --- | --- | | **Introduced by** | #2131 (2023-09-07), "Execution dashboard frontend". `filterByStatus` was the Status column filter; `dataCheck` gated the polling update of a row | | **Usage removed by** | #3105 (2025-01-15), "Execution Dashboard Backend Pagination & Frontend Loading Icon". It replaced `[nzFilterFn]="filterByStatus"` with `[nzFilterFn]="true"` and deleted the only `this.dataCheck(...)` call | They have been dead for about twenty months, with only spec cases keeping them in use. ### Any related issues, documentation, discussions? Closes #8718 ### How was this PR tested? No new tests. The spec drops from 53 to 49 cases, losing only the four cases for the removed members. From `frontend/`: - `npx ng test --watch=false --include='**/admin-execution.component.spec.ts'`: 49 tests, all pass. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n "dataCheck\|filterByStatus" -- frontend # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
