mengw15 commented on PR #8729: URL: https://github.com/apache/texera/pull/8729#issuecomment-5862231830
Dropping the backport labels — neither defect is a regression; each arrived with the code that introduced it. The blob leak arrived with the blobs: #5675 (2026-07-19) added `createObjectURL` and put `revokeObjectURL` in `ngOnDestroy` in the same commit, while row navigation had been there since #2109. And the un-torn-down `selectTuple` subscription came in with #1682 (2022-10-07), the commit that added row switching in the first place — it was a bare `.subscribe()` then, with no teardown at all; `untilDestroyed` was a later improvement, never a per-row one. Worth noting for whoever picks this up later: `release/v1.2` has only the second defect. #5675 is not on that branch, so there are no object URLs there for `releaseRow()` to revoke, and this patch would need adapting rather than cherry-picking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
