carloea2 opened a new pull request, #8792:
URL: https://github.com/apache/texera/pull/8792

   ### What changes were proposed in this PR?
   
   Use STRING only when a nonempty inference sample contains no non-null value 
for a column. The INTEGER seed otherwise causes later text rows to be 
discarded. Preserve nulls and numeric inference where values were observed.
   
   Before: blank sample, INTEGER inference, later text lost.
   After: blank sample, STRING inference, later text retained.
   
   All-null numeric samples also become STRING; an explicit Type Cast can 
select a numeric type.
   
   ### Any related issues, documentation, discussions?
   
   Closes #8791
   
   Related to #7568; its numeric-with-blanks behavior is retained.
   
   ### How was this PR tested?
   
   Fresh checks on upstream main 98d3d4b1ec: all 34 CSV tests passed, including 
upstream's new negative-window test and the added regressions. Both module 
scalafix checks and repository Scala formatting passed.
   
   ```text
   sbt "WorkflowOperator/testOnly 
org.apache.texera.amber.operator.source.scan.csv.CSVScanSourceOpExecSpec 
org.apache.texera.amber.operator.source.scan.csv.CSVScanSourceOpDescSpec" 
"WorkflowOperator/scalafix --check" "WorkflowOperator/Test/scalafix --check" 
scalafmtCheckAll
   ```
   
   Earlier localhost reproduction in Chrome at 1707 by 979: the same synthetic 
workflow returned 102 of 103 rows before and all 103 after, preserving `José 
東京` and `00042`. Regression failures were observed before the implementation.
   
   Same input and saved workflow. Panel layouts differ because the baseline 
used the results-panel candidate; no panel change is included here.
   
   | Before CSV change | After CSV change |
   | --- | --- |
   | ![Before CSV 
change](https://github.com/user-attachments/assets/d5b7a746-44ab-473f-98a6-0341b9ac4b7a)
 | ![After CSV 
change](https://github.com/user-attachments/assets/d2adcb83-075f-455c-ad89-430ea67d6133)
 |
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: OpenAI Codex (exact authoring version not recorded).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to