aglinxinyuan opened a new pull request, #8817: URL: https://github.com/apache/texera/pull/8817
### What changes were proposed in this PR? Removes `dictionaryChangedSubject` from `UserConfigService`: the private field, its three `.next()` calls in `updateEntry` / `updateDict`, and the now-unused rxjs `Subject` import. **+8/−49 lines.** There is no behaviour change. The Subject was private with no getter, so nothing could subscribe to it. `updateEntry` and `updateDict` keep their guards, deletes and assignments; only the emissions go. In the spec, two cases that only counted emissions are deleted. Two others are kept, with their emission assertions replaced by behaviour checks, because they cover the surviving guards: a repeated `set()` still issues a PUT and keeps the entry, and deleting an absent key leaves the dictionary untouched. ### History | | | | --- | --- | | **Introduced by** | #1162 (2021-06-27), "Add UserDictionaryService (User Presets Step 2)". The field was private from the start, with no getter or `asObservable()` | | **Usage removed by** | **never used**. The only readers were spec cases reaching the private field through `(service as any)` | It has been unused for over five years. ### Any related issues, documentation, discussions? Closes #8816 ### How was this PR tested? No new tests. The two kept cases now pin the guards' behaviour instead of emission counts. From `frontend/`: - `npx ng test --watch=false --include='**/user-config.service.spec.ts' --include='**/preset.service.spec.ts'`: 2 files, 68 tests, all pass. `PresetService` is the only production consumer of `UserConfigService`. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n -i "dictionaryChanged" -- frontend # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
