aglinxinyuan opened a new pull request, #8825: URL: https://github.com/apache/texera/pull/8825
### What changes were proposed in this PR? Removes the unused test-database JDBC URL setting. **+5/−20 lines.** There is no behaviour change. - `StorageConfig.jdbcUrlForTestCases` and the `storage.jdbc.url-for-test-cases` key in `storage.conf` (with its `STORAGE_JDBC_URL_FOR_TEST_CASES` override and comment). They go together, because the val's eager `getString` would throw once the key is gone. - The "Not the test-cases database: ..." sentence in four RunSpecs (amber, access-control, config, notebook-migration). It explained their `pooledJdbcUrl shouldBe StorageConfig.jdbcUrl` assertion by contrast with this setting. The assertions and the remaining credential note are unchanged. > Reviewer note: the two `Create texera_db_for_test_cases` CI steps in `build.yml` deliberately **stay**. `backport-checks.yml` runs `main`'s `build.yml` against `release/*` trees, and on `release/v1.1` and `release/v1.2` the e2e `TestUtils` still connects to that database. For the same reason this change must not be backported to v1.1 or v1.2, where it would not compile. ### History | | | | --- | --- | | **Introduced by** | #3782 (2025-10-07), "feat(amber): enable user system by default", for the e2e `TestUtils.initiateTexeraDBForTestCases` | | **Usage removed by** | #6238 (2026-07-27), "refactor: Refactor MockTexeraDB into a JVM singleton". That helper now creates its own per-run database on the embedded Postgres instead of reading this URL | It has been unused on `main` for two months. ### Any related issues, documentation, discussions? Closes #8824 ### How was this PR tested? No new tests. `StorageConfigSpec` has no assertion on the removed setting. Locally, from the repo root with Java 17: - `sbt "Config/Test/compile" "DAO/Test/compile" "WorkflowExecutionService/Test/compile" "ConfigService/Test/compile" "AccessControlService/Test/compile" "NotebookMigrationService/Test/compile"`: success. - `sbt "Config/testOnly *StorageConfigSpec"`: 7 tests, all pass. - `sbt "Config/scalafmtCheckAll" "Config/scalafixAll --check"`, plus `scalafmtCheckAll` on the four modules whose specs changed: clean. To re-check: ``` git grep -n "jdbcUrlForTestCases\|url-for-test-cases\|URL_FOR_TEST_CASES" # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
