aglinxinyuan opened a new pull request, #8879: URL: https://github.com/apache/texera/pull/8879
### What changes were proposed in this PR? Removes two rules from the hub About page's stylesheet that style nothing: `#logo` and `.login-container`. **−11 lines.** There is no behaviour change. The component uses emulated encapsulation, so these rules can only match its own template, and no element there uses either selector, statically or dynamically. No code adds them at runtime, and no other stylesheet relies on them. ### History | | | | --- | --- | | **Introduced by** | #2324 (2024-01-24), "Remove bootstrap from navigation bars": `#logo`. #3119 (2024-12-01), "Update Texera Hub About Page": `.login-container` | | **Usage removed by** | #2725 (2024-09-24), "Add Hub", removed the `<li id="logo">` element; the stylesheet then moved with the component unchanged. #7339 (2026-08-10), "consolidate login onto a dedicated /login page", removed the embedded `<texera-local-login class="login-container">` | `#logo` has been dead for two years and `.login-container` for two months. ### Any related issues, documentation, discussions? Closes #8878 ### How was this PR tested? No new tests; no spec referenced either selector. From `frontend/`: - `npx ng test --watch=false --include='**/about.component.spec.ts' --include='**/user-icon.component.spec.ts'`: 2 files, 5 tests, all pass. The user-icon spec routes to the About page. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n "login-container" -- frontend # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
