aglinxinyuan opened a new pull request, #8877:
URL: https://github.com/apache/texera/pull/8877
### What changes were proposed in this PR?
Removes the unused `R = TypeVar("R")` from pyamber's `async_rpc_client.py`,
and drops `TypeVar` from its `typing` import, which only existed for it.
**+1/−3 lines.** There is no behaviour change: nothing in the file refers to
`R`, and the module's two importers (`main_loop.py` and its test) import only
`AsyncRPCClient` and `async_run`.
### History
| | |
| --- | --- |
| **Introduced by** | #2950 (2024-10-31), "Migrate scala control messages to
protobuf", together with the `TypeVar` import |
| **Usage removed by** | **never used**. No annotation, `Generic[R]` or
string annotation has ever referred to it |
It has been unused for the eleven months since it was added.
### Any related issues, documentation, discussions?
Closes #8876
### How was this PR tested?
No new tests.
From `amber/`:
- `ruff check src/main/python src/test/python && ruff format --check
src/main/python src/test/python`: clean.
- `python -m pytest -m "not integration"
src/test/python/core/architecture/rpc/test_async_rpc_client.py`: 12 tests, all
pass.
To re-check:
```
git grep -n 'TypeVar("R")' # no hits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
