aglinxinyuan opened a new pull request, #8896:
URL: https://github.com/apache/texera/pull/8896

   ### What changes were proposed in this PR?
   
   Removes three exported REST endpoint constants from 
`execute-workflow.service.ts` that nothing imports: 
`EXECUTE_WORKFLOW_ENDPOINT`, `PAUSE_WORKFLOW_ENDPOINT` and 
`RESUME_WORKFLOW_ENDPOINT`. **−5 lines.** There is no behaviour change. 
Execute, pause and resume are sent over the websocket (`WorkflowExecuteRequest` 
/ `WorkflowPauseRequest` / `WorkflowResumeRequest`), and the backend has no 
`queryplan/execute`, `pause` or `resume` REST routes.
   
   ### History
   
   | | |
   | --- | --- |
   | **Introduced by** | #622 (2018-06-21), the first execute-workflow service: 
`EXECUTE_WORKFLOW_ENDPOINT`. #684 (2019-03-10), pause/resume buttons: the other 
two |
   | **Usage removed by** | #811 (2020-08-21), the Amber merge, which moved 
pause/resume to websocket requests and removed their `http.post` calls. #982 
(2021-01-25), "Improves multiple ports support in Texera operators (Step 4)", 
which removed the last REST execute call |
   
   The pause/resume constants have been unused for six years, and the execute 
one for nearly five.
   
   ### Any related issues, documentation, discussions?
   
   Closes #8895
   
   ### How was this PR tested?
   
   No new tests; no spec imported the constants.
   
   From `frontend/`:
   
   - `npx ng test --watch=false`, covering `execute-workflow.service.spec.ts` 
plus all 17 specs that import the service (18 files): 1363 tests pass, 1 is 
skipped (an existing `it.skip`).
   - `yarn format:ci`: clean.
   - `npx ng build`: success.
   
   To re-check:
   
   ```
   git grep -n -w -E 
"EXECUTE_WORKFLOW_ENDPOINT|PAUSE_WORKFLOW_ENDPOINT|RESUME_WORKFLOW_ENDPOINT"   
# no hits
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5.5)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to