aglinxinyuan opened a new pull request, #8892: URL: https://github.com/apache/texera/pull/8892
### What changes were proposed in this PR? Removes the unused `@Output() loadFile` from `UserDatasetFileRendererComponent`, along with `EventEmitter` and `Output` from its `@angular/core` import, since nothing else in the file uses them. **+1/−4 lines.** There is no behaviour change: the component never emits `loadFile`, and its two hosts (`dataset-detail` and `model-detail`) bind only inputs on `<texera-user-dataset-file-renderer>`. ### History | | | | --- | --- | | **Introduced by** | #2413 (2024-02-26), "Introduce Dataset GUI", with the file renderer itself | | **Usage removed by** | **never used**. No `(loadFile)` binding or `.emit` has ever existed | It has been unused for the nineteen months since it was added. ### Any related issues, documentation, discussions? Closes #8891 ### How was this PR tested? No new tests; no spec referenced the output. From `frontend/`: - `npx ng test --watch=false --include='**/user-dataset-file-renderer.component.spec.ts' --include='**/dataset-detail.component.spec.ts' --include='**/model-detail.component.spec.ts'`: 3 files, 286 tests, all pass. The last two specs cover the renderer's two hosts. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n -w "loadFile" -- frontend/src # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
