carloea2 commented on code in PR #8350:
URL: https://github.com/apache/texera/pull/8350#discussion_r4254659363
##########
frontend/src/app/workspace/component/menu/menu.component.ts:
##########
@@ -393,8 +412,8 @@ export class MenuComponent implements OnInit, OnDestroy {
disable: boolean;
onClick: () => void;
} {
- // If workflow is invalid, always disable and show "Invalid Workflow"
- if (!this.isWorkflowValid) {
+ // If workflow is invalid or does not compile, always disable and show
"Invalid Workflow"
+ if (!this.isWorkflowValid || !this.isWorkflowCompilable) {
Review Comment:
This compilation gate also disables controls for an existing execution. A
late background compile response can arrive after the run starts. Reproduced in
the real MenuComponent template under Chromium: with valid validation and a
connected unit, emitting Failed while Running or Paused replaces Pause or
Resume with disabled Invalid Workflow. Please apply the compilation gate to
starting a new run, while keeping the active execution controls available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
