kz930 commented on code in PR #8350:
URL: https://github.com/apache/texera/pull/8350#discussion_r4255202530
##########
frontend/src/app/workspace/component/menu/menu.component.ts:
##########
@@ -393,8 +412,8 @@ export class MenuComponent implements OnInit, OnDestroy {
disable: boolean;
onClick: () => void;
} {
- // If workflow is invalid, always disable and show "Invalid Workflow"
- if (!this.isWorkflowValid) {
+ // If workflow is invalid or does not compile, always disable and show
"Invalid Workflow"
+ if (!this.isWorkflowValid || !this.isWorkflowCompilable) {
Review Comment:
@carloea2 Fixed in 2440bc004. The compile gate now applies only in the
states where the button starts a new run. While a run is active, Pause and
Resume stay available. Added a regression test that sends a failed compile
while Running and while Paused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
