Xiao-zhen-Liu commented on code in PR #7122:
URL: https://github.com/apache/texera/pull/7122#discussion_r4261812166
##########
amber/src/test/scala/org/apache/texera/amber/engine/architecture/scheduling/RegionExecutionManagerTestSupport.scala:
##########
@@ -242,8 +256,10 @@ object RegionExecutionManagerTestSupport {
trait RegionExecutionManagerTestSupport { self: TestKit =>
import RegionExecutionManagerTestSupport._
- protected def createCoordinatorHarness(): CoordinatorHarnessFixture = {
- val coordinatorRef = TestActorRef(new CoordinatorHarness)
+ protected def createCoordinatorHarness(
+ rpcProbe: CoordinatorRpcProbe = new CoordinatorRpcProbe(_ => None)
+ ): CoordinatorHarnessFixture = {
+ val coordinatorRef = TestActorRef(new CoordinatorHarness(rpcProbe))
Review Comment:
The new test still passes with the fire-and-forget version: the harness is
still a `TestActorRef`, so the cleanup message is handled inside the `!` call,
and `beforeCleanup` blocks the sender before either version returns. For this
test, the harness needs to be a normal actor that handles messages on its own
thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
