zyratlo commented on code in PR #8910:
URL: https://github.com/apache/texera/pull/8910#discussion_r4287604015
##########
frontend/src/app/workspace/service/notebook-migration/migration-llm.ts:
##########
@@ -111,15 +111,66 @@ function toDerivedNotebook(cells: DerivedCell[]):
Notebook {
outputs: [],
execution_count: null,
})),
- metadata: {
- kernelspec: { display_name: "Python 3", language: "python", name:
"python3" },
- language_info: { name: "python" },
- },
+ metadata,
Review Comment:
Fixed in
[4a1f3bd](https://github.com/apache/texera/pull/8910/commits/4a1f3bd21e412c5c34dc112286efe6ca6c8f4bda).
`toDerivedNotebook` now clones the prompt set's metadata, so each derived
notebook gets its own copy, as it did before the refactor. A new test mutates
one conversion's metadata and checks that the next conversion is unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
