Ma77Ball commented on code in PR #8978:
URL: https://github.com/apache/texera/pull/8978#discussion_r4287683696
##########
common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/source/scan/file/FileScanSourceOpExecSpec.scala:
##########
@@ -38,8 +38,11 @@ import java.util.zip.{ZipEntry, ZipOutputStream}
*/
class FileScanSourceOpExecSpec extends AnyFlatSpec with BeforeAndAfterAll {
- /** Execution id whose object prefix the large binaries created here are
written under. */
- private val testExecutionId: Long = 8888L
+ /**
+ * Execution id whose object prefix the large binaries created here are
written under.
+ * Negative because real execution ids are positive, so deleting its prefix
spares real runs.
Review Comment:
Ty @ShawnGarello for raising this pr. Overall, this PR LGTM. I just left 2
nits to review.
> [!tip]
Nit: It's okay to point out something wrong in the repo, but please fix it
as soon as you notice it (don't leave comments suggesting the logic is wrong).
Best practice is to update the comments to reflect the current logic, or, if
the current logic is incorrect, to fix the code to match the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
