ShawnGarello commented on code in PR #8978:
URL: https://github.com/apache/texera/pull/8978#discussion_r4291441216
##########
common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/source/scan/file/FileScanSourceOpExecSpec.scala:
##########
@@ -185,6 +191,11 @@ class FileScanSourceOpExecSpec extends AnyFlatSpec with
BeforeAndAfterAll {
assert(field.isInstanceOf[LargeBinary])
assert(field.asInstanceOf[LargeBinary].getUri.startsWith("s3://"))
Review Comment:
Good catch, applied in 47f5665. Thanks!
##########
common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/source/scan/file/FileScanSourceOpExecSpec.scala:
##########
@@ -38,8 +38,11 @@ import java.util.zip.{ZipEntry, ZipOutputStream}
*/
class FileScanSourceOpExecSpec extends AnyFlatSpec with BeforeAndAfterAll {
- /** Execution id whose object prefix the large binaries created here are
written under. */
- private val testExecutionId: Long = 8888L
+ /**
+ * Execution id whose object prefix the large binaries created here are
written under.
+ * Negative because real execution ids are positive, so deleting its prefix
spares real runs.
Review Comment:
Thanks, updated the comments in 47f5665 to describe what the code does,
including `baseUriForExecution`'s doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
