aglinxinyuan opened a new pull request, #9112: URL: https://github.com/apache/texera/pull/9112
### What changes were proposed in this PR? Removes `AiAnalystService`'s unused `workflowActionService` constructor injection and its import. **+2/−9 lines.** There is no behaviour change. The field is public, but nothing reads it: not the service, its one consumer `ReportGenerationService` (which uses its own `WorkflowActionService`), any template or any spec. Nothing builds the service by hand; Angular DI creates it, and `WorkflowActionService` is provided in root, so dropping the parameter is safe. The spec drops its empty `WorkflowActionService` stub, whose comment already said it existed only for this unused dependency. ### History | | | | --- | --- | | **Introduced by** | #2816 (2024-10-15), "Enhancing Report Generation by Adding Story-teller Ai based on Ai flag" | | **Usage removed by** | **never used** | It has been unused for the two years since it was added. ### Any related issues, documentation, discussions? Closes #9109 ### How was this PR tested? No new tests. From `frontend/`: - `npx ng test --watch=false --include='**/ai-analyst.service.spec.ts' --include='**/report-generation.service.spec.ts' --include='**/menu.component.spec.ts'`: 3 files, 178 tests, all pass. The last two specs cover the service's consumer. - `npx tsc --noEmit -p src/tsconfig.app.json` and `-p src/tsconfig.spec.json`: clean. - `yarn format:ci`: clean. - `npx ng build`: success. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
