hongzhi-gao commented on code in PR #745:
URL: https://github.com/apache/tsfile/pull/745#discussion_r2980697038
##########
cpp/src/reader/chunk_reader.cc:
##########
@@ -490,4 +504,82 @@ int
ChunkReader::decode_tv_buf_into_tsblock_by_datatype(ByteStream& time_in,
return ret;
}
+bool ChunkReader::should_skip_page_by_time(int64_t min_time_hint) {
+ if (min_time_hint < 0) {
+ return false;
+ }
Review Comment:
I changed the min_time_hint sentinel logic to use INT64_MIN instead of
checking < 0, so negative timestamps are handled correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
