hongzhi-gao commented on code in PR #745:
URL: https://github.com/apache/tsfile/pull/745#discussion_r2980716271
##########
cpp/src/reader/tsfile_reader.cc:
##########
@@ -116,6 +114,41 @@ int TsFileReader::query(const std::string& table_name,
return ret;
}
+int TsFileReader::queryByRow(std::vector<std::string>& path_list, int offset,
+ int limit, ResultSet*& result_set) {
+ int ret = E_OK;
+ std::vector<Path> path_list_vec;
+ for (const auto& path : path_list) {
+ path_list_vec.emplace_back(Path(path, true));
+ }
+ QueryExpression* query_expression =
+ QueryExpression::create(path_list_vec, nullptr);
+ ret =
+ tsfile_executor_->execute(query_expression, result_set, offset, limit);
+ return ret;
+}
+
+int TsFileReader::queryByRow(const std::string& table_name,
+ const std::vector<std::string>& column_names,
+ int offset, int limit, ResultSet*& result_set) {
+ int ret = E_OK;
+ TsFileMeta* tsfile_meta = tsfile_executor_->get_tsfile_meta();
+ if (tsfile_meta == nullptr) {
+ return E_TSFILE_WRITER_META_ERR;
Review Comment:
I replaced the reader-side null-meta return code with E_FILE_READ_ERR
instead of E_TSFILE_WRITER_META_ERR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
