[ 
http://jira.xwiki.org/jira/browse/XWIKI-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_22593
 ] 

Marius Dumitru Florea commented on XWIKI-2105:
----------------------------------------------

Vincent,

The desired behavior would be:

* deleteDocument => EVENT_DELETE
* saveDocument => EVENT_NEW if doc.isNew() or EVENT_CHANGE otherwise

Sorry for the poor explanation. I meant "other events ... must be fired" in 
general, not specifically by saveDocument. Other events include 
EVENT_UPDATE_CONTENT, EVENT_UPDATE_OBJECT and EVENT_UPDATE_CLASS. I made this 
issue a blocker because I need it for the Curriki 1.5.1 release. But you should 
be aware that we are still using XWiki Core 1.1 so the fix must be included in 
this branch also.

Sergiu, please commit what you have as soon as possible.

Thanks.

> Notifications - Always EVENT_CHANGE
> -----------------------------------
>
>                 Key: XWIKI-2105
>                 URL: http://jira.xwiki.org/jira/browse/XWIKI-2105
>             Project: XWiki Core
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.2
>         Environment: Any
>            Reporter: Marius Dumitru Florea
>            Priority: Blocker
>
> In com.xpn.xwiki.XWiki#saveDocument(XWikiDocument, String, XWikiContext) 
> there is only:
> // Notify listeners about the document change
> getNotificationManager().verify(doc, originalDocument, 
> XWikiDocChangeNotificationInterface.EVENT_CHANGE, context);
> In com.xpn.xwiki.XWiki#deleteDocument(XWikiDocument, XWikiContext) there is 
> only:
> getNotificationManager().verify(new XWikiDocument(doc.getSpace(), 
> doc.getName()), doc, XWikiDocChangeNotificationInterface.EVENT_CHANGE, 
> context);
> Other events like EVENT_NEW, EVENT_DELETE etc. must be fired. See 
> com.xpn.xwiki.notify.XWikiDocChangeNotificationInterface for a full list of 
> possible events.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.xwiki.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
notifications mailing list
notifications@xwiki.org
http://lists.xwiki.org/mailman/listinfo/notifications

Reply via email to