[ 
http://jira.xwiki.org/jira/browse/XWIKI-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_22600
 ] 

Marius Dumitru Florea commented on XWIKI-2105:
----------------------------------------------

I changed deleteDocument and saveDocument methods locally to meet the desired 
behavior but the result is the same. After a closer inspection I discovered 
that the NotificationManager ignores the event parameter. Also, 
DocChangeRule#verify(XWikiDocument, XWikiDocument, XWikiContext) always fires 
EVENT_CHANGE, which is not surprising given the fact it doesn't get the event 
parameter from the NotificationManager.

> Notifications - Always EVENT_CHANGE
> -----------------------------------
>
>                 Key: XWIKI-2105
>                 URL: http://jira.xwiki.org/jira/browse/XWIKI-2105
>             Project: XWiki Core
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.2
>         Environment: Any
>            Reporter: Marius Dumitru Florea
>            Priority: Blocker
>
> In com.xpn.xwiki.XWiki#saveDocument(XWikiDocument, String, XWikiContext) 
> there is only:
> // Notify listeners about the document change
> getNotificationManager().verify(doc, originalDocument, 
> XWikiDocChangeNotificationInterface.EVENT_CHANGE, context);
> In com.xpn.xwiki.XWiki#deleteDocument(XWikiDocument, XWikiContext) there is 
> only:
> getNotificationManager().verify(new XWikiDocument(doc.getSpace(), 
> doc.getName()), doc, XWikiDocChangeNotificationInterface.EVENT_CHANGE, 
> context);
> Other events like EVENT_NEW, EVENT_DELETE etc. must be fired. See 
> com.xpn.xwiki.notify.XWikiDocChangeNotificationInterface for a full list of 
> possible events.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.xwiki.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
notifications mailing list
notifications@xwiki.org
http://lists.xwiki.org/mailman/listinfo/notifications

Reply via email to