[ 
https://issues.apache.org/jira/browse/YETUS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988258#comment-14988258
 ] 

Chris Nauroth commented on YETUS-142:
-------------------------------------

This looks good to me overall, with the caveat that I'm not well-versed in the 
typical output to expect from Gradle.

{code}
  ${GREP} -E '^.*\.(c|cc|h|hh|.cxx|.cpp)\:[[:digit:]]*\:' "${input}" > 
"${output}"
{code}

I think the {{digit}} check syntax is specific to GNU grep, right?  Are we 
sticking with GNU grep as a requirement, or are we aiming to be more flexible?

I have come across some other file extensions for C++ code: .C, .c++, .H, .hxx, 
.hpp, .h++.  I find some of these pretty odd personally, but maybe consider 
expanding the regex to allow projects that use them?

> compile gets limited to 'warning' in generic log handler
> --------------------------------------------------------
>
>                 Key: YETUS-142
>                 URL: https://issues.apache.org/jira/browse/YETUS-142
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>         Attachments: YETUS-142.00.patch, YETUS-142.01.patch, 
> YETUS-142.02.patch
>
>
> This is clearly a hold over from when it was purely java.  But as a result, 
> it breaks cc and scalac problem detection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to