[ 
https://issues.apache.org/jira/browse/YETUS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988291#comment-14988291
 ] 

Allen Wittenauer commented on YETUS-142:
----------------------------------------

bq.  I think the digit check syntax is specific to GNU grep, right?

I seem to recall [~sekikn] wrote another patch using `digit`.  I thought the 
same thing and was going to -1 the patch.  But it's extremely unlike them to 
stray from POSIX so I did my homework.  
http://pubs.opengroup.org/onlinepubs/009696899/basedefs/xbd_chap09.html  Pop 
down to section 9.3.5.

I think it took a while for my jaw to come back up.

bq. I have come across some other file extensions for C++ code: .C, .c+, .H, 
.hxx, .hpp, .h+. I find some of these pretty odd personally, but maybe consider 
expanding the regex to allow projects that use them?

Yeah, we probably should.  I might slap a -i on that to simplify things.  I'll 
fire up another patch with that fix here in a sec.

Thanks for the review!

> compile gets limited to 'warning' in generic log handler
> --------------------------------------------------------
>
>                 Key: YETUS-142
>                 URL: https://issues.apache.org/jira/browse/YETUS-142
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>         Attachments: YETUS-142.00.patch, YETUS-142.01.patch, 
> YETUS-142.02.patch
>
>
> This is clearly a hold over from when it was purely java.  But as a result, 
> it breaks cc and scalac problem detection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to