symat commented on a change in pull request #1254: ZOOKEEPER-2164: Quorum
members can not rejoin after restart
URL: https://github.com/apache/zookeeper/pull/1254#discussion_r381856296
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
##########
@@ -552,10 +577,13 @@ private void handleConnection(Socket sock,
DataInputStream din) throws IOExcepti
try {
InitialMessage init =
InitialMessage.parse(protocolVersion, din);
sid = init.sid;
- electionAddr = new MultipleAddresses(init.electionAddr,
-
Duration.ofMillis(self.getMultiAddressReachabilityCheckTimeoutMs()));
+ if (!init.electionAddr.isEmpty()) {
Review comment:
well, theoretically it is possible that someone adds both wildcard address
and normal IP / FQDN for a multi-address config, but that doesn't make much
sense. I would rather throw an exception at startup in this case... The whole
point of multi-address is to use different networks for redundancy, so you
should always provide FQDN / IP there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
