eolivelli commented on a change in pull request #1314: ZOOKEEPER-3791:
Miscellaneous Maven fixes
URL: https://github.com/apache/zookeeper/pull/1314#discussion_r410016658
##########
File path: pom.xml
##########
@@ -904,8 +898,8 @@
<inherited>false</inherited>
<configuration>
<!-- update the version inside the C sources -->
- <preparationGoals>clean install -DskipTests
antrun:run@replace-cclient-files-during-release
scm:add@add-cclient-files-during-release
scm:checkin@commit-cclient-files-during-release</preparationGoals>
- <completionGoals>clean install -DskipTests
antrun:run@replace-cclient-files-during-release
scm:add@add-cclient-files-during-release
scm:checkin@commit-cclient-files-during-release</completionGoals>
+ <preparationGoals>clean verify -Pfull-build,fatjar -DskipTests
antrun:run@replace-cclient-files-during-release
scm:add@add-cclient-files-during-release
scm:checkin@commit-cclient-files-during-release</preparationGoals>
+ <completionGoals>clean verify -Pfull-build,fatjar -DskipTests
antrun:run@replace-cclient-files-during-release
scm:add@add-cclient-files-during-release
scm:checkin@commit-cclient-files-during-release</completionGoals>
Review comment:
good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services