ctubbsii commented on a change in pull request #1314: ZOOKEEPER-3791:
Miscellaneous Maven fixes
URL: https://github.com/apache/zookeeper/pull/1314#discussion_r409500657
##########
File path: pom.xml
##########
@@ -265,15 +265,8 @@
<id>fatjar</id>
<modules>
<module>zookeeper-it</module>
- <module>zookeeper-contrib/zookeeper-contrib-fatjar</module>
Review comment:
> I think it would be good to move the `zookeeper-contrib-fatjar` module to
the top-level directory and have a separate maven profile to build it.
I agree it should be moved, but I think it would be better done as its own
distinct follow-on task. This PR is already a bit overloaded, don't you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
