kabhishek4 commented on code in PR #2280:
URL: https://github.com/apache/zookeeper/pull/2280#discussion_r2241523215
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/IPAuthenticationProvider.java:
##########
@@ -55,9 +62,16 @@ public List<Id> handleAuthentication(HttpServletRequest
request, byte[] authData
// This is a bit weird but we need to return the address and the number of
// bytes (to distinguish between IPv4 and IPv6
private byte[] addr2Bytes(String addr) {
- byte[] b = v4addr2Bytes(addr);
- // TODO Write the v6addr2Bytes
- return b;
+ if (addr.contains(":")) {
+ LOG.info("Attempting to parse as IPv6...");
Review Comment:
Ok, changed the code likewise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
