kabhishek4 commented on PR #2280: URL: https://github.com/apache/zookeeper/pull/2280#issuecomment-3159142972
> > Overall looks good to me, thanks @kabhishek4 ! Have you considered using a 3rd party library instead, for instance https://github.com/seancfoley/IPAddress ? > > You might want to add some more unit tests to validate the actual parsing logic for properly formatted addresses: check if the returned byte array matches. > > No, I have not considered using a third party. I worked on the proposed approach only. > > Could you please elaborate on adding test case? Do you mean adding new case in ACLTest.java or some other file? Also, it is not clear to me returned byte address needs to be compared with which entity? Could you please let me know? @anmolnar I have added new test cases. Please review and let me know your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
