Hello It's great that this might finally get done. But there is one problem currently.
If you open a large search buffer and then do *-<tab> it will die as the tagging routine runs notmuch search to find a completion-list for the tag. (it runs notmuch search --output=tags <query>) We could just return all tags in this case. Or we could do something like the series id:1354263691-19715-1-git-send-email-markwalters1009 at gmail.com which makes completion happen based on the tags visible to the user, not the tags actually in the database. There is also a little discussion of this in my earlier attempt at fixing this: eg id:87mwy4smad.fsf at qmul.ac.uk Best wishes Mark On Mon, 07 Oct 2013, Austin Clements <amdragon at MIT.EDU> wrote: > I was hacking on undo support for notmuch-emacs and sort of > accidentally wrote this instead. This series fixes a set of > well-known races where tagging from search-mode unexpectedly affects > messages that arrived after the search was performed (and hence the > user doesn't know they're tagging them). We've attacked this a few > times before, but have always run up against something that was > missing. It turns out the pieces are finally all in place. > > The first five patches just clean various things up in preparation. > Patches 6 and 7 add support for tagging large queries, which would > otherwise become a problem when later patches start using explicit > message ID-based queries for tagging. The remaining four patches > actually fix the search tagging races using explicit message ID-based > queries. > > It's a fairly long series, but none of the patches are very big. > > _______________________________________________ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch