Am Montag, den 30.04.2012, 21:42 +0200 schrieb Francisco Jerez: > Lucas Stach <d...@lynxeye.de> writes: > > > Am Montag, den 30.04.2012, 20:08 +0200 schrieb Francisco Jerez: > >> Lucas Stach <d...@lynxeye.de> writes: > >>[...] > >> > + /* only advertise supported texture formats */ > >> > + memset(&ctx->TextureFormatSupported, 0, > >> > + sizeof(ctx->TextureFormatSupported)); > >> > + ctx->TextureFormatSupported[MESA_FORMAT_XRGB8888] = true; > >> > + ctx->TextureFormatSupported[MESA_FORMAT_ARGB8888] = true; > >> > + ctx->TextureFormatSupported[MESA_FORMAT_RGB565] = true; > >> > + ctx->TextureFormatSupported[MESA_FORMAT_Z16] = true; > >> > + ctx->TextureFormatSupported[MESA_FORMAT_Z24_S8] = true; > >> > + > >> Hi Lucas, > >> > >> It's not obvious to me how this works. AFAIK nouveau doesn't make use > >> of this array. And even if it did, the texture formats you're listing > >> aren't the supported ones. > > > > Hello Francisco, > > > > The core mesa code decides what texture formats to advertise based on > > this array. > > Are you sure? TextureFormatSupported doesn't seem to have any effect > except in drivers that use mesa's default for the ChooseTextureFormat > hook.
I'm not able to test it myself, as I don't have any vieux hardware, but I made sure that the patch got tested by the reporter of the bug [1], before posting it to the list. [1] https://bugs.freedesktop.org/show_bug.cgi?id=49148 > > > And obviously someone thought it would be a good idea to > > init this array to "everything supported" if the driver doesn't > > overrides this. > > > > I opted to only advertise renderable texture formats, for reasons > > explained in my mail a minute ago. _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
