Whatever. I do know how to send patch to lkml. Do whatever you see right. Alon.
On 5/27/08, Bernhard Kaindl <[EMAIL PROTECTED]> wrote: > On Sat, 24 May 2008, Alon Bar-Lev wrote: > > > > OK, > > > > The attached patch does the followings: > > > > 1. Add --enable-mount-helper, default enabled on linux. > > 2. Trivial fixup casing in --disable-device-default-io-ops > > 3. Add --with-rootfs drop the uses of none standard exec-prefix, lib and > core utils will be installed here, default / > > 4. Warn fuse none rootfs only if rootfs is / > > 5. Dependency of sbin. > > 6. As it is none standard to install anything out side of prefix, added > DISTCHECK_HACK=1 environment that "make distcheck" works > > > > Please review. > > > In my personal opinion, you should not submit patches for review in this way > because it makes the review which you ask for very hard to do. > > Other projects like the linux kernel have developed a good practice of > demanding > that developers spit up big patches which do many different things smaller > ones > which are easyer to review and give each patch more description than just > one line which also includes a justification why this patch is needed or > suggested. > > And when a entirely new series of patches is sent, a new thread is started, > (they do not go into the old thread) and a new, descriptive subject line for > the new patches is choosen. > > You even mixed a trivial upper/lowercase fixup into these important big > changes > one of which removes a feature which was announced to be required to be used > in > previous release notes(1). Mixing such important and heavvy changes with > noise > makes a thoughtful review even harder. > > Bernhard > > PS: > > About (1): > > The changed number 3 > > " 3. Add --with-rootfs drop the uses of none standard exec-prefix, lib and > core > utils will be installed here, default /" > > removes the actually standard --exec-prefix and replaces it with the > non-standard > "--with-rootfs". Using a different exec-prefix has been announced as a > required > change for fuse and ntfs-3g in the release notes of ntfs-3g-1.616: > > > > http://article.gmane.org/gmane.comp.file-systems.ntfs-3g.devel/207 > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ ntfs-3g-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
