Hi Alon and Bernhard,
Thanks for the patch, testing, and comments.
The man8 part looks definitely good but I think the patch still doesn't
guarantee that $(DESTDIR)/sbin will be created (I tracked down the bug
was introduced by me).
Could we have the --disable-mount-helper option for this code? Linux
would create /sbin/mount.ntfs-3g by default unless the option is used.
Other OSes would default to --disable-mount-helper.
An alternative could be --enable-mount-helper=<full_path>. Default to
/sbin/mount.ntfs-3g on Linux and disabled for others.
Thanks,
Szaka
On Mon, 19 May 2008, Bernhard Kaindl wrote:
> On Mon, 19 May 2008, Alon Bar-Lev wrote:
> >
> > Make sure that the directory install rule is completed before using it.
>
> My review and test:
>
> At first I tought:
>
> Your description does not make it obvious to me why you remove
>
> > - $(INSTALL) -d "$(DESTDIR)$(rootsbindir)"
>
> and
>
> > - $(INSTALL) -d "$(DESTDIR)$(man8dir)"
>
> from src/Makefile.am.
>
> But indeed adding this
>
> > -install-data-local:
> > +install-data-local: install-man8
>
> does make the "make install" create the directories needed so the two
> '$(INSTALL) -d "$(DESTDIR)' are not needed anymore.
>
> I tested your change with make and make install with '-j' and looks good.
>
> So this change looks good to me.
>
> Thanks,
> Bernhard
>
> > --- src/Makefile.am 3 Feb 2008 16:39:13 -0000 1.9
> > +++ src/Makefile.am 19 May 2008 04:55:16 -0000
> > @@ -37,12 +37,10 @@
> > $(LDCONFIG)
> > endif
> >
> > -install-exec-local:
> > - $(INSTALL) -d "$(DESTDIR)$(rootsbindir)"
> > +install-exec-local: install-rootsbinDATA
> > $(LN_S) -f "$(rootbindir)/ntfs-3g" "$(DESTDIR)/sbin/mount.ntfs-3g"
> >
> > -install-data-local:
> > - $(INSTALL) -d "$(DESTDIR)$(man8dir)"
> > +install-data-local: install-man8
> > $(LN_S) -f ntfs-3g.8 "$(DESTDIR)$(man8dir)/mount.ntfs-3g.8"
> >
> > uninstall-local:
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> ntfs-3g-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
>
--
NTFS-3G: http://ntfs-3g.org
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
ntfs-3g-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
