Hi,
Bogdan wrote:
> Hello everybody.
>
> I've prepared a small patch for utils.c and ntfswipe.c:
> - in utils.c, checking for allocated blocks is fixed to pre-fetch
> data on the first run,
>
- if ((lcn < bmplcn)
+ if ((bmplcn < 0) || (lcn < bmplcn)
|| (lcn >= (long long)(bmplcn + (sizeof(buffer) << 3)))) {
Can you explain this one ?
AFAIK lcn is always >= 0 there, and bmplcn can only be
negative when it is == -(sizeof(buffer) << 3), so the last
condition is true when bmplcn is negative.
So the change does nothing.
> - in ntfswipe.c, wiping file tails in enhanced and wiping undelete
> data is introduced.
>
This a long one, I will check later.
> Additionally, a small correction is added to the layout.h file
> (change from floating-point constant to long long), so that there
> are no warnings when ntfsck.c is being compiled. You can make this
> conditional, there are autoconf tests that check for support of the
> "long long" type in the C compiler.
>
Hmm, this patch is wrong :
-#define magicNTFS const_cpu_to_le64(0x202020205346544e) /*
"NTFS " */
+#define magicNTFS const_cpu_to_le64(0x202020205346544ll) /*
"NTFS " */
> It would be nice if you could make the "list.h" header a part of
> the public API/development package, with "NTFS_" or "ntfs_" prefixes
> on the symbols.
>
Do you have a real need ? I am reluctant to change
external names which can break existing applications.
> Please reply also to my e-mail address (not only to the list) when
> replying to this mail.
>
> If you can see this mail, then it means you have to subscribe to the
> mailing list to be able to post messages (while on your website you
> said this list is open).
Correct.
Regards
Jean-Pierre
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
ntfs-3g-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
