Hi again, Bogdan wrote:
>> const int NTFS_BUF_SIZE2 = 8192; >> char buf[NTFS_BUF_SIZE2]; >> >> This is not portable, change to a good old "#define" >> >> const int NTFS_BUF_SIZE2 = 4096; >> >> same, and as this is a different value, an explanation to what both >> values mean may be useful. >> > Yes, it would be. You may ask the author, because these declarations > aren't a part of my patch and I don't know why there are 2 separate > variables with different values. > Oh, sorry for the confusion. >> ret = ntfs_rl_pread(vol, na->rl, offset, 2,&block_size); >> block_size = le16_to_cpu(block_size); >> >> This creates confusion, as block_size has a couple of representations. >> Please use another variable such as : >> >> le16 block_size_le; >> ret = ntfs_rl_pread(vol, na->rl, offset, 2,&block_size_le); >> block_size = le16_to_cpu(block_size_le); >> >> indx_record_size = le32_to_cpu(indx_record_size); >> >> Same issue as above. >> > Also not my changes. I don't know what should these variables contain. > Well, another item to put on my todo list... Regards Jean-Pierre ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ ntfs-3g-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
