Never came through to my system - looks like a couple of messages didn't make it on those days s'be'it...
Comments... * sFlow - remember, sFlow could be seeing IPv6 data on a non-V6 host. Are you sure you want to remove all IPv6 processing? * uintnn_t vs. u_intnn_t. Rather than put a bunch of #ifdef everywhere, why don't you fix it right? The uintnn_t types appear only one or two places in all of ntop while the corresponding u_intnn_t types appear in 100s. $ codegrep uint8_t globals-core.h:955:#define IN6_IS_ADDR_MULTICAST(a) (((uint8_t *) (a))[0] == 0xff) globals-structtypes.h:57:typedef u_char uint8_t; pbuf.c:3797: uint8_t sof = 0, eof = 0, error = 0; Gets rid of junk like this: +#if defined(WIN32) && defined(__GNUC__) + u_int16_t protocolId; +#else uint16_t protocolId; +#endif * If MinGW doesn't support 64 bit counters, you have a lot of problems w/ roll-over. So this is probably wrong: #if defined(WIN32) && defined(__GNUC__) -typedef unsigned long long u_int64_t; /* on mingw unsigned long is 32 bits */ +//typedef unsigned long long u_int64_t; /* on mingw unsigned long is 32 bits */ #else You have to figure SOMETHING out for u_int64_t. * Rather than commenting bad crud out, just remove it: #if defined(WIN32) && defined(__GNUC__) -extern char *gdbm_strerror(gdbm_error errno); +//extern char *gdbm_strerror(gdbm_error errno); #endif * Unless it's clearer (i.e. code at each level), don't code this: #if defined(WIN32) && defined(__GNUC__) #ifndef _GETOPT_H #ifndef HAVE_GETOPT_H ... #endif /* HAVE_GETOPT_H */ #endif /* _GETOPT_H */ #endif /* WIN32 && __GNUC__ */ Instead: #if defined(WIN32) && defined(__GNUC__) && !defined(_GETOPT_H) && !defined(HAVE_GETOPT_H) #endif /* Win32 && __GNUC__ && !_GETOPT_H && !HAVE_GETOPT_H (FWIW, _GETOPT_H is local to getopt.c and so unnecessary - the line in plugins\rrdPlugin.c s/b removed) * WRT globals-defines.h change, the point if the #ifdef WIN32 stuff is to define those things which don't exist for the MS VC++ compiler. You may need to provide different definitions, so you may need to add a #ifdef __GNUC__ set, but... rather than removing these for MinGW and then adding dozens of #ifdef lines in the code, why don't you follow suit? -----Burton -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of jacengel Sent: Monday, August 29, 2005 9:35 AM To: [email protected] Subject: RE: [Ntop-dev] Patches and documentation for building ntop on MingW Burton, Message sent by Georger on Sunday 8-21-2005 has attachment patches.zip Cheers Jac -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Burton Strauss Sent: maandag 29 augustus 2005 15:51 To: [email protected] Subject: RE: [Ntop-dev] Patches and documentation for building ntop on MingW Georger, I haven't *SEEN* any patches from you, just pointers to .tgz files of source. -----Burton -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Georger Araujo Sent: Saturday, August 27, 2005 3:12 PM To: [email protected] Subject: RE: [Ntop-dev] Patches and documentation for building ntop on MingW Hi Jac, sorry for taking so long to answer, I got sick AGAIN, this time much harder, 5 days on heavy medicine - and still recovering. This is based on CVS as of Aug 20th. About going back to 2004, my bad - I sent the wrong BUILD-MinGW.txt file (the patches are OK). I'll send the correct one as soon as I get access to my laptop again, I left it at the office and I haven't been there since Tuesday. You probably noticed I turned back to using old versions of gd and libpng, and that's easy to explain: using the latest versions required deeper hacking of source files along with introducing lots of DLL dependencies, while gaining (in my envinronment) ZERO security, stability, functionality or performance. I only kept gdbm 1.8.3-1 because it's more stable and faster than 1.8.0. I'll look at bumping zlib 1.2.1 to 1.2.3 as soon as I get better. This is not really related to any issue in particular, I just polished my changes so that they won't break anything in the *nix world, while remaining 100% compatible with MingW. Burton, any luck integrating my patches? Regards, Georger --- jacengel <[EMAIL PROTECTED]> escreveu: > Georger, > What version is this ? going back to 2004 with instructions ? What is > the relation of the issue you sent to me ? > > Cheers > Jac > > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On > Behalf Of Georger Araujo > Sent: zondag 21 augustus 2005 15:17 > To: [email protected] > Subject: [Ntop-dev] Patches and documentation for building ntop on > MingW > > > Burton, > I have made patches and updated the documentation for building ntop on > MingW. They're in the attachment. > They're based on ntop CVS as of yesterday (Aug 20th). > They also incorporate the patch you sent below. > I explicitly disabled IPv6 in globals-defines.h and ntop_win32.h. As I > don't have IPv6 on my network, I can't test it. I also put a lot of > #ifdefs in sflowPlugin.c to handle the lack of IPv6 as well. I removed > my sources from savefile.com - the only thing there now is libs. > Those willing to compile > ntop on MingW will have to fetch CVS sources and do their homework. I > REALLY appreciate ntop and all the effort that has been put into it. > Thanks. > Regards, > > Georger _______________________________________________________ Yahoo! Acesso Grátis - Internet rápida e grátis. Instale o discador agora! http://br.acesso.yahoo.com/ _______________________________________________ Ntop-dev mailing list [email protected] http://listgateway.unipi.it/mailman/listinfo/ntop-dev _______________________________________________ Ntop-dev mailing list [email protected] http://listgateway.unipi.it/mailman/listinfo/ntop-dev _______________________________________________ Ntop-dev mailing list [email protected] http://listgateway.unipi.it/mailman/listinfo/ntop-dev _______________________________________________ Ntop-dev mailing list [email protected] http://listgateway.unipi.it/mailman/listinfo/ntop-dev
