On Thu, 2019-05-23 at 10:17 -0400, Marten van Kerkwijk wrote: > I agree that we should not have two functions > > I also am rather unsure whether a ufunc is a good idea. Earlier, > while discussing other possible additions, like `erf`, the conclusion > seemed to be that in numpy we should just cover whatever is in the C > standard. This suggests `sinc` should not be a ufunc. >
We are not adding a function though, as Robert already noted. So this
is about how much we prefer ufuncs for functions that are a perfect
fit.
The accuracy can certainly be improved, but it involves some branching,
so I think we would see at least 50% speed penalty compared to the
ufunc version in the end (right now the speed improvement is about 20%
for larger arrays, much more for smaller of course).
I do not have a perfect feeling about what the precision improvements
mean exactly here, but I posted some relative errors below as
additional stats [0].
Overall I think I would be pretty neutral if there was no gain at all
(as there is some loss of maintainability). Here it seems that we have
some decent enhancement as well though, so I am slightly in favor.
Best,
Sebastian
[0] And here maybe an additional point for better relative precision:
```
xarr = np.linspace(0, 2.1, 200000)
res = []
for x in xarr:
res.append((np.sinc(x) - mpmath.sincpi(x))/mpmath.sincpi(x))
res = np.asarray(res, dtype=object)
print(abs(res).mean(), abs(res).max())
```
master:
1.70112344295248e-15 6.61977521930425e-11
New branch:
5.64884361112036e-17 4.01208410359583e-16
we probably should have tests if we add this.
> -- Marten
>
> p.s.`scipy.special.sinc` *is* `np.sinc`
>
> p.s.2 The accuracy argument is not in itself an argument for a ufunc,
> as it could be done in python too.
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion@python.org
> https://mail.python.org/mailman/listinfo/numpy-discussion
signature.asc
Description: This is a digitally signed message part
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@python.org https://mail.python.org/mailman/listinfo/numpy-discussion
