On Thu, Sep 2, 2010 at 10:25 AM, Charles R Harris <charlesr.har...@gmail.com > wrote:
> > > On Thu, Sep 2, 2010 at 8:51 AM, Jason McCampbell < > jmccampb...@enthought.com> wrote: > >> >> >> On Wed, Sep 1, 2010 at 9:07 PM, Charles R Harris < >> charlesr.har...@gmail.com> wrote: >> >>> >>> Hi Jason, >>> >>> On Tue, Aug 31, 2010 at 2:56 PM, Jason McCampbell < >>> jmccampb...@enthought.com> wrote: >>> >>>> Hi Chuck (and anyone else interested), >>>> >>>> I updated the refactoring page on the NumPy developer wiki (seems to be >>>> down or I'd paste in the link). It certainly isn't complete, but there are >>>> a lot more details about the data structures and memory handling and an >>>> outline of some additional topics that needs to be filled in. >>>> >>>> >>> I note that there are some C++ style comments in the code which will >>> cause errors on some platforms, so I hope you are planning on removing them >>> at some point. Also, >>> >> >> Mostly the C++ comments are there for specific things we need to fix >> before it's complete (easier to search for). Likely a few are attributable >> to "muscle memory" in my fingers as well, but all will be removed as we >> button it up. >> >> >>> >>> if (yes) foo; >>> >>> is very bad style. There is a lot of that in old code like that that >>> still needs to be cleaned up, but I also see some in the new code. It would >>> be best to get it right to start with. >>> >> >> Agreed. In the code I have edited I typically re-write it as "if (NULL != >> yes) foo;" but a lot of code has been copied in wholesale and we haven't >> always updated that code. >> >> > > I mean it is bad style to have foo on the same line as the if. I think this > happens because folks start off wanting to save a bit of vertical space and > a couple of keystrokes, but in the long run it tends to make the code harder > to read. > Oh, that's interesting. I don't generally have an objection to 'foo' on the same line for simple statement as, like you said, it saves a lot of vertical space and the lack of curly's is more of an issue with: if (yes) foo; I try to avoid the C-ism of default conversion of pointers to a bool comparison. Jason
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion