[ https://issues.apache.org/jira/browse/NUTCH-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775365#action_12775365 ]
Andrzej Bialecki commented on NUTCH-764: ----------------------------------------- First question is: why is it sometimes vfsfile:// ? What you propose is just hiding the problem, and not solving it - Nutch does not support this protocol, so we should not pretend to do so. More specifically, plugins can only be loaded from locations accessible through the file:// protocol, and pretending that we can load them from vfsfile:// (whatever it may be) is just not true, even if it works in your specific case. Second question: does it work with this fix, i.e. is Nutch able to load the plugins using this protocol? > Add support for vfsfile:// loading of plugins for JBoss > ------------------------------------------------------- > > Key: NUTCH-764 > URL: https://issues.apache.org/jira/browse/NUTCH-764 > Project: Nutch > Issue Type: Improvement > Components: searcher > Affects Versions: 1.0.0 > Environment: JBoss AS 5.1.0 > Reporter: tcur...@approachingpi.com > Priority: Trivial > > In the file: > /src/java/org/apache/nutch/plugin/PluginManifestParser.java > There is a check to make sure that the plugin file location is a url > formatted like "file://path/plugins". > When deployed on Jboss, the file protocol will sometimes be: > "vfsfile://path/plugins". The code with vfsfile can operate the same so I > propose a change to the check to also allow this protocol. This would allow > Nutch to be deployed on the newer versions of JBoss without any modification. > Here is a simple patch: > Index: src/java/org/apache/nutch/plugin/PluginManifestParser.java > =================================================================== > --- src/java/org/apache/nutch/plugin/PluginManifestParser.java Mon Nov > 09 20:20:51 EST 2009 > +++ src/java/org/apache/nutch/plugin/PluginManifestParser.java Mon Nov > 09 20:20:51 EST 2009 > @@ -121,7 +121,8 @@ > } else if (url == null) { > LOG.warn("Plugins: directory not found: " + name); > return null; > - } else if (!"file".equals(url.getProtocol())) { > + } else if (!"file".equals(url.getProtocol()) && > + !"vfsfile".equals(url.getProtocol())) { > LOG.warn("Plugins: not a file: url. Can't load plugins from: " + > url); > return null; > } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.