[
https://issues.apache.org/jira/browse/NUTCH-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776064#action_12776064
]
Andrzej Bialecki commented on NUTCH-764:
-----------------------------------------
Thanks for the explanation. Well, it's surprising that it works - in that
method in the manifest parser we return a java.io.File constructed from this
URL, and we expect that it's a regular java.io.File directory. Next question
is: if this is a cache, then perhaps the first time you obtain a resource it
returns a file:// but on subsequent calls it returns vfsfile:// and you didn't
experience any problems because plugins were loaded just once? I'm guessing
here - I don't use JBoss.
> Add support for vfsfile:// loading of plugins for JBoss
> -------------------------------------------------------
>
> Key: NUTCH-764
> URL: https://issues.apache.org/jira/browse/NUTCH-764
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Affects Versions: 1.0.0
> Environment: JBoss AS 5.1.0
> Reporter: tcur...@approachingpi.com
> Priority: Trivial
>
> In the file:
> /src/java/org/apache/nutch/plugin/PluginManifestParser.java
> There is a check to make sure that the plugin file location is a url
> formatted like "file://path/plugins".
> When deployed on Jboss, the file protocol will sometimes be:
> "vfsfile://path/plugins". The code with vfsfile can operate the same so I
> propose a change to the check to also allow this protocol. This would allow
> Nutch to be deployed on the newer versions of JBoss without any modification.
> Here is a simple patch:
> Index: src/java/org/apache/nutch/plugin/PluginManifestParser.java
> ===================================================================
> --- src/java/org/apache/nutch/plugin/PluginManifestParser.java Mon Nov
> 09 20:20:51 EST 2009
> +++ src/java/org/apache/nutch/plugin/PluginManifestParser.java Mon Nov
> 09 20:20:51 EST 2009
> @@ -121,7 +121,8 @@
> } else if (url == null) {
> LOG.warn("Plugins: directory not found: " + name);
> return null;
> - } else if (!"file".equals(url.getProtocol())) {
> + } else if (!"file".equals(url.getProtocol()) &&
> + !"vfsfile".equals(url.getProtocol())) {
> LOG.warn("Plugins: not a file: url. Can't load plugins from: " +
> url);
> return null;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
