On Fri, May 13, 2022 at 12:14:51PM -0700, Dan Williams wrote: > On Fri, May 13, 2022 at 8:12 AM Luis Chamberlain <[email protected]> wrote: > > But with CONFIG_FAIL_FUNCTION this means you don't have to open code > > should_fail() calls, but instead for each routine you want to add a failure > > injection support you'd just use ALLOW_ERROR_INJECTION() per call. > > So cxl_test takes the opposite approach and tries not to pollute the > production code with test instrumentation. All of the infrastructure > to replace calls and inject mocked values is self contained in > tools/testing/cxl/ where it builds replacement modules with test > instrumentation. Otherwise its a maintenance burden, in my view, to > read the error injection macros in the nominal code paths.
Is relying on just ALLOW_ERROR_INJECTION() per routine you'd want to enable error injection for really too much to swallow? Luis
