Hi, On 6 September 2016 at 18:00, Michael Marth <mma...@adobe.com> wrote:
> Hi, > > I think it would be neat if we could utilize our existing mechanism rather > than a new flag. In particular, MVCC and branches for session isolation. > And also simply use session.save() to indicate that an upload is complete > (and the branch containing the binaries/chunks can be merged). > Do branches and sessions hang around between requests ? Each body part will come from different requests, sometimes separated by hours and possibly even from different source IP addresses, especially under upload restart conditions. At present, in streaming mode, as each body part is encountered a session.save is performed to cause JCR/Oak to read that input stream from the request, since JCR does not expose anything that can be used to write binary data to the repository. Best Regards Ian > > Michael > > Sent from a mobile device > > > > > On Tue, Sep 6, 2016 at 1:15 PM +0200, "Marcel Reutegger" < > mreut...@adobe.com<mailto:mreut...@adobe.com>> wrote: > > Hi, > > On 06/09/16 12:34, Bertrand Delacretaz wrote: > > On Tue, Sep 6, 2016 at 9:49 AM, Marcel Reutegger <mreut...@adobe.com> > wrote: > >> ...we'd still have to add > >> Jackrabbit API to support it. E.g. something like: > >> > >> valueFactory.createBinary(existingBinary, appendThisInputStream); ... > > > > And maybe a way to mark the binary as "in progress" to avoid > > applications using half-uploaded binaries? > > This can easily be prevented if the 'in progress' binary is > uploaded to a temporary location first and then copied over > to the correct location once complete. Keep in mind that > copying a large existing binary in Oak is simply a cheap > copy of the reference. > > Regards > Marcel >
