Hi, Recently I experienced a problem with another PR build, and it seemed caused by build infrastructure issues.
This time, I thought the same is happening again, and before merging PR (that added new test cases and updated doc), run tests locally. I am sorry I have rushed with the PR approval that caused project build issues later on. Matt, your suggestion sounds reasonable. Regards, Miroslav On Thu, Mar 10, 2022 at 4:33 PM Marcel Reutegger <[email protected]> wrote: > Hi, > > On 08.03.22, 15:55, "Matt Ryan" <[email protected]> wrote: > > - Open issues, questions, concerns, etc. in tickets and PRs must be > > addressed satisfactorily before code is committed. > > I agree. To me it seems like changes for OAK-9712 were rushed in. > The PR also had failed checks for most of the modules, because > a license header was missing. I admit, a missing license header > is not a big deal. But it looks like for this PR the Jenkins test results > were simply ignored and impact could have been worse. > > Regards > Marcel >
